New gauge group, plus minor changes to error generator classes #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyjmurray
commented
Jul 25, 2025
There was a problem hiding this comment.
Changes to this file are incidental. They seemed in the spirit of type annotations, although the argument verification at the end of __init__ is new.
…mpatibiity with python 3.9
coreyostrove
approved these changes
Jul 26, 2025
…eGroupElement._to_nice_serialization and DirectSumUnitaryGroupElement._to_nice_serialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pulled out of PR #410. The main change is the new gauge group which handles subgroups of unitaries that have a block-diagonal structure. Along the way I added type annotations throughout error generator code. I also cleaned up code in LindbladCoefficientBlock._block_data_to_params.